]> dgit.raspbian.org Git - gnome-shell.git/commit
mpris: Hide notification when !CanPlay, instead of closing player
authorPhilip Chimento <philip@endlessm.com>
Tue, 29 Oct 2019 00:11:40 +0000 (17:11 -0700)
committerFlorian Müllner <florian.muellner@gmail.com>
Tue, 29 Oct 2019 19:25:16 +0000 (19:25 +0000)
commit4dc44304dff2974d3b026b5aa58e0d5c25d38216
treec9a97cabaf2411c88a20f47d6a0504bd47fa5874
parent975280fc50651bd67c3551840cf3026b2d75a33b
mpris: Hide notification when !CanPlay, instead of closing player

I have observed a client in the wild (Chromium again) set CanPlay to
false momentarily while it is loading the next song. Previously, the
code would close the player proxy in that case, meaning that after
playing one track, the MPRIS message would disappear and never come
back.

However, I think this use of CanPlay, while apparently not usual, is not
incorrect according to the spec. We should hide the message instead of
closing the player proxy.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/1362
js/ui/mpris.js